<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 28/09/13 19:44, Edward Petrie-Smith
wrote:<br>
</div>
<blockquote cite="mid:37807.1380393886@petrie-smith.net" type="cite">
<style> BODY { font-family:Arial, Helvetica, sans-serif;font-size:12px; }</style>All,<br>
<br>
I have just installed version 2.5.4 from source on my Ubuntu
platform.<br>
<br>
I remember coming across a patch that included the ability to
embed album art into the mp3 being created by abcde, and managed
to find it available from <a moz-do-not-send="true"
href="http://code.google.com/p/abcde/issues/detail?id=33.">http://code.google.com/p/abcde/issues/detail?id=33.</a><br>
<br>
I've used patch in the past to patch binaries etc. (<a
moz-do-not-send="true"
href="http://www.cyberciti.biz/faq/appy-patch-file-using-patch-command/%29">http://www.cyberciti.biz/faq/appy-patch-file-using-patch-command/)</a>
but struggling with how I go about installing the patch here.<br>
<br>
Could somebody please help me here by explaining what I need to
patch abcde here? Can I just apply the patch in isolation, or do I
need to install patches 0001-0004 before I can apply this patch. <br>
<br>
Edward.<br>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Abcde-users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Abcde-users@lists.einval.com">Abcde-users@lists.einval.com</a>
<a class="moz-txt-link-freetext" href="http://lists.einval.com/cgi-bin/mailman/listinfo/abcde-users">http://lists.einval.com/cgi-bin/mailman/listinfo/abcde-users</a></pre>
</blockquote>
Hi Edward, those are my patches. Try this:<br>
<br>
First download the version of the code that the patches were applied
against. I quickly tested patching the current head but the patches
don't apply cleanly to it.<br>
<br>
$svn co <a class="moz-txt-link-freetext" href="http://abcde.googlecode.com/svn/tags/2.5.4">http://abcde.googlecode.com/svn/tags/2.5.4</a> abcde-254<br>
<br>
Next, download the patches<br>
<br>
$ curl -o 0001-Add-support-for-Album-Artist.patch
<a class="moz-txt-link-rfc2396E" href="http://abcde.googlecode.com/issues/attachment?aid=160003000&name=0001-Add-support-for-Album-Artist.patch&token=zk_B_DshhFRXk64h5ycs7ISphs4%3A1388518179383">"http://abcde.googlecode.com/issues/attachment?aid=160003000&name=0001-Add-support-for-Album-Artist.patch&token=zk_B_DshhFRXk64h5ycs7ISphs4%3A1388518179383"</a><br>
<br>
$ curl -o 0002-Allow-user-to-select-genre.patch
<a class="moz-txt-link-rfc2396E" href="http://abcde.googlecode.com/issues/attachment?aid=850001000&name=0002-Allow-user-to-select-genre.patch&token=IHmqPf6J1ExHA4zSEL3HCTmhtto%3A1388518852952">"http://abcde.googlecode.com/issues/attachment?aid=850001000&name=0002-Allow-user-to-select-genre.patch&token=IHmqPf6J1ExHA4zSEL3HCTmhtto%3A1388518852952"</a><br>
<br>
$ curl -o 0003-Use-addstatus-checkstatus-around-do_albumartist.patch
<a class="moz-txt-link-rfc2396E" href="http://abcde.googlecode.com/issues/attachment?aid=160003001&name=0003-Use-addstatus-checkstatus-around-do_albumartist.patch&token=xHAAQTmlQff1K-c1Oc5Vq2HOIAg%3A1388518179383">"http://abcde.googlecode.com/issues/attachment?aid=160003001&name=0003-Use-addstatus-checkstatus-around-do_albumartist.patch&token=xHAAQTmlQff1K-c1Oc5Vq2HOIAg%3A1388518179383"</a><br>
<br>
$ curl -o 0004-Add-support-for-album-art-download-and-embed.patch
<a class="moz-txt-link-rfc2396E" href="http://abcde.googlecode.com/issues/attachment?aid=330012000&name=0004-Add-support-for-album-art-download-and-embed.patch&token=eDTqUYAum0GUv2hB9anz38K6fiI%3A1388518568592">"http://abcde.googlecode.com/issues/attachment?aid=330012000&name=0004-Add-support-for-album-art-download-and-embed.patch&token=eDTqUYAum0GUv2hB9anz38K6fiI%3A1388518568592"</a><br>
<br>
$ curl -o 0005-Embed-album-art-in-Flac-and-Ogg.patch
<a class="moz-txt-link-rfc2396E" href="http://abcde.googlecode.com/issues/attachment?aid=330015000&name=0005-Embed-album-art-in-Flac-and-Ogg.patch&token=HnUqsNVRK6tHSu-dr5JsoG8uLoM%3A1388518568593">"http://abcde.googlecode.com/issues/attachment?aid=330015000&name=0005-Embed-album-art-in-Flac-and-Ogg.patch&token=HnUqsNVRK6tHSu-dr5JsoG8uLoM%3A1388518568593"</a><br>
<br>
those are the patches downloaded from ABCDE issues 16, 33 and 85.
Next, apply them<br>
<br>
$ cd abcde-254<br>
$ patch < ../0001-Add-support-for-Album-Artist.patch<br>
$ patch < ../0002-Allow-user-to-select-genre.patch<br>
$ patch <
../0003-Use-addstatus-checkstatus-around-do_albumartist.patch<br>
$ patch <
../0004-Add-support-for-album-art-download-and-embed.patch<br>
$ patch < ../0005-Embed-album-art-in-Flac-and-Ogg.patch<br>
<br>
That should give you a patched abcde and abcde.conf. It's almost a
year since I looked at this but, if I recall correctly, the patches
are additive so you will need to apply them all in sequence.<br>
<br>
If you prefer, you can download from my Git repository,
<a class="moz-txt-link-freetext" href="https://github.com/johnlane/abcde">https://github.com/johnlane/abcde</a>, this repo is already patched so
just clone that and you'll be good to go. In case you aren't a git
user:<br>
<br>
$ git clone <a class="moz-txt-link-freetext" href="https://github.com/johnlane/abcde.git">https://github.com/johnlane/abcde.git</a><br>
<br>
Hope that's of some assistance.<br>
<br>
PS. I'm curious... will those patches ever make it into the
"official" version?<br>
<br>
Happy new year!<br>
<br>
John<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
</body>
</html>