<div dir="ltr"><div class="gmail_default" style="font-family:"courier new",monospace"><div class="gmail_default">Just to close this off from my POV anyway:</div><div class="gmail_default"><br></div><div class="gmail_default"><br></div><div class="gmail_default">1. I have installed the patch Gabriel circulated, and tested it with 4 CDs, and various combinations for CDDBMETHOD, and it all seems to have worked.</div><div class="gmail_default"><br></div><div class="gmail_default">2. Using the modified permissions (i.e. running SUID root) on cdda2wav did give me CD-TEXT as expected when CDDB lookup failed.</div><div class="gmail_default"><br></div><div class="gmail_default">3. I tried installing icedax in place of cdda2wav on openSUSE. It installs with normal permissions for executables - no suid - and runs fine for normal users.</div><div class="gmail_default"><br></div><div class="gmail_default">Thanks Gabriel</div><div class="gmail_default"><br></div><div class="gmail_default">Slainte</div><div class="gmail_default">Gordon</div><div class="gmail_extra" style="font-family:arial,sans-serif"><br><div class="gmail_quote">On Fri, Sep 2, 2016 at 10:09 PM, Gabriel Rosenkoetter <span dir="ltr"><<a href="mailto:gr@eclipsed.net" target="_blank">gr@eclipsed.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 26 Aug, 2016, at 18:58EDT, Gabriel Rosenkoetter <<a href="mailto:gr@eclipsed.net">gr@eclipsed.net</a>> wrote:<br>> I’m thinking in particular of CDDBMETHOD here, but there are probably other places where this might be handy.<br><br>Short version:<br><br>The attached patch (see also <a href="https://abcde.einval.com/bugzilla/show_bug.cgi?id=42" rel="noreferrer" target="_blank">https://abcde.einval.com/<wbr>bugzilla/show_bug.cgi?id=42</a>), if applied to your local abcde, will make CDDBMETHOD accept a comma-separated list of CDDB resolution methods. If you’ve only got one thing set for that in your CDDBMETHOD (that is, you have no commas there), it shouldn’t break anything. I would recommend setting “CDDBMETHOD=musicbrainz,cddb”, but that’s just me.<br><br></blockquote></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Sep 3, 2016 at 6:05 PM, Gordon Findlay <span dir="ltr"><<a href="mailto:gfindlay.linux@gmail.com" target="_blank">gfindlay.linux@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default"><font face="arial, helvetica, sans-serif">As Gabriel commented, abcde did not read any CD-TEXT information for me. These details are what I have so far:</font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif"><br></font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif">1: abcde uses icedax or cdda2wav (in do_cdtext() ) to read it. I am using openSUSE Leap 42.1, in which icedax is not installed, so abcde tries to use cdd2a2wav. That <b>is</b> installed (version 3.01).</font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif"><br></font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif">2: in a default installation of openSUSE, a standard user cannot run cdda2wav, due to privilege issues like these:</font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif"><br></font></div><div class="gmail_default"><font size="1" face="monospace, monospace"><span style="color:rgb(0,0,0)">cdda2wav: Operation not permitted. Cannot regain process capabilities.
</span><br>cdda2wav: Insufficient 'file read' privileges. You will not be able to open all needed devices.
<br>cdda2wav: Insufficient 'file write' privileges. You will not be able to open all needed devices.
<br>cdda2wav: Insufficient 'device' privileges. You may not be able to send all needed SCSI commands, this my cause various unexplainable problems. <br>cdda2wav: Insufficient 'priocntl' privileges. You may get jitter.</font></div><div class="gmail_default"><font size="1" face="monospace, monospace">cdda2wav: Insufficient 'network' privileges. You will not be able to do remote SCSI. <br>cdda2wav: Operation not permitted. Cannot regain process capabilities. <br>cdda2wav: Permission denied. Cannot open '/dev/sg1'. Cannot open or use SCSI driver. <br>cdda2wav: For possible targets try 'cdda2wav -scanbus'. Make sure you are root. </font><br></div><div class="gmail_default"><font face="arial, helvetica, sans-serif"><br></font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif">cdda2wav works fine for root, or using sudo</font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif"><br></font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif">3: The default (at least for SUSE) perms are </font></div><div class="gmail_default"><font face="monospace, monospace"><span style="color:rgb(0,0,0)">-rwxr-xr-x 1 root root 262944 Oct 25 2015 </span><font color="#000000">cdda2wav</font></font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif" color="#000000"><br></font></div><div class="gmail_default"><font color="#000000" face="monospace, monospace">chmod u+s cdda2wav</font><font face="arial, helvetica, sans-serif" color="#000000"> resolves the problem, so normal users can execute cdda2wav. This is the quick fix.</font><br><span style="font-family:monospace;color:rgb(0,0,0)">
</span><br></div><div class="gmail_default">4. Running programs suid root like this is anathema to some. According to the cdrtools web site it is possible to be more subtle using the setcap to assign more fine-grained privileges. A default installation of openSUSE doesn't include setcap either :-)</div><div class="gmail_default" style="font-family:"courier new",monospace"></div><div class="gmail_default"><font face="arial, helvetica, sans-serif">I will test the patch for a ranking list of CDDBMETHOD in a little while - tomorrow I hope.</font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif"><br></font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif">Thanks to Gabriel for forcing me to investigate this. I wish I had checked what was going on before I used a different technique altogether to get CDs with no CDDB/MusicBrainz entries (I used cd_info, a dodgy script, and a lot of cut and paste). cd_info gives different formatted output to either icedax or cdda2wav. so I guess using it as CDTEXT_READER in abcde would be difficult.</font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif"><br></font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif">Slainte</font></div><span class="HOEnZb"><font color="#888888"><div class="gmail_default"><font face="arial, helvetica, sans-serif">Gordon</font></div></font></span><span class=""><div class="gmail_default" style="font-family:"courier new",monospace"><span style="font-family:monospace"><br></span></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 2, 2016 at 10:09 PM, Gabriel Rosenkoetter <span dir="ltr"><<a href="mailto:gr@eclipsed.net" target="_blank">gr@eclipsed.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 26 Aug, 2016, at 18:58EDT, Gabriel Rosenkoetter <<a href="mailto:gr@eclipsed.net" target="_blank">gr@eclipsed.net</a>> wrote:<br>
> I’m thinking in particular of CDDBMETHOD here, but there are probably other places where this might be handy.<br>
<br>
Short version:<br>
<br>
The attached patch (see also <a href="https://abcde.einval.com/bugzilla/show_bug.cgi?id=42" rel="noreferrer" target="_blank">https://abcde.einval.com/bugzi<wbr>lla/show_bug.cgi?id=42</a>), if applied to your local abcde, will make CDDBMETHOD accept a comma-separated list of CDDB resolution methods. If you’ve only got one thing set for that in your CDDBMETHOD (that is, you have no commas there), it shouldn’t break anything. I would recommend setting “CDDBMETHOD=musicbrainz,cddb”, but that’s just me.<br>
<br>
Please let me know if you apply this patch and have problems as a result. I don’t think i broke anything, but it’s really hard to test for unknowns.<br>
<br>
Long version:<br>
<br>
I’ve cc’ed a few people explicitly here (and I would encourage you to drop the explicit ccs if you’re responding to this to the list, in order to reduce everybody’s inbox noise):<br>
* Steve, because he and I have had some off-list exchanges about this, and … I guess I just want to make his inbox catchup worse? Huh, maybe I shouldn’t actually send you two copies of this. (And now I’m not.)<br>
* Gordon, because he responded, inadvertently dropping the list address (we discussed that, and agreed that I’d go ahead and summarize our conversation back here) to my original email about this (quoted in abbreviation above) saying, broadly, “Yeah, i want that too!”. Gordon also made some good points about how, in absence of MusicBrainz or CDDB records for a given CD, maybe just fall back to CD-TEXT? The existing code does fall through to CD-TEXT in something like that case, but I’m not convinced it works the way a theoretical new user thinks it should. The details of this get into CDTEXT_READER behavior, and that’s just not a thing I’ve looked at carefully. Gordon, please feel to expand on this.<br><br>
</blockquote></div><br></div></span></div>
</blockquote></div><br></div>