<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Marcin Wojtas [mailto:mw@semihalf.com]
<br>
<b>Sent:</b> Sunday, March 04, 2018 3:18 PM<br>
<b>To:</b> Stefan Chulski <stefanc@marvell.com><br>
<b>Cc:</b> Steve McIntyre <steve@einval.com>; macchiato@lists.einval.com<br>
<b>Subject:</b> Re: [Macchiato] [EXT] Network driver crash<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Hi Stefan,<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">2018-03-04 13:35 GMT+01:00 Stefan Chulski <<a href="mailto:stefanc@marvell.com" target="_blank">stefanc@marvell.com</a>>:<o:p></o:p></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12.0pt">> >IRQ requested during interface open procedure.<br>
> >So you should do "ifconfig eth2 up".<br>
> >I don't have mainline code right now, but should be something like this:<br>
> ># ifconfig eth2 up<br>
> ># cat /proc/interrupts | grep eth2<br>
> >134: 1 0 0 0 ICU 129 Level f4000000.ppv22.eth2.link<br>
> >135: 0 0 0 0 ICU 39 Level f4000000.ppv22.eth2.cpu0<br>
> >136: 0 0 0 0 ICU 43 Level f4000000.ppv22.eth2.cpu1<br>
> >137: 0 0 0 0 ICU 47 Level f4000000.ppv22.eth2.cpu2<br>
> >138: 0 0 0 0 ICU 51 Level f4000000.ppv22.eth2.cpu3<br>
><br>
> Nope, not seeing that here:<br>
><br>
> steve@mjolnir:~$ sudo ifconfig eth2 up<br>
> steve@mjolnir:~$ cat /proc/interrupts | grep eth2<br>
> 70: 0 0 0 0 GICv2 294 Level eth2<br>
<br>
Packet processor use ICU interrupts...<br>
<br>
Could you please share your dtb file, boot log and ifconfig -a output.<br>
<br>
<o:p></o:p></p>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">The DTB that Stuart was running, use older binding (ICU -> GIC mapping basing on the ATF configuration). Do you think it can matter?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
<p class="MsoNormal"><span style="color:#1F497D">Yes. Look like it cause issue.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Each TX done interrupt mapped to specific CPU by smp_affinity and without IRQ balancing. Look like with old dtb interrupt raised on wrong CPU’s.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">You can work around this issue by disabling TX Done interrupts in mvpp2_port_has_tx_irqs<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span style="color:#1F497D"> for (i = 0; i < 5; i++) {<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span style="color:#1F497D"> ret = of_property_match_string(port_node, "interrupt-names",<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span style="color:#1F497D"> irqs[i]);<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span style="color:#1F497D"> if (ret < 0)<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span style="color:#1F497D"> return false;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"> }<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span style="color:#1F497D">- return true;<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span style="color:#1F497D">+ return false;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Stefan,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Best Regards.<o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</body>
</html>