[Abcde-users] abcde

[Reuben Thomas]

On 30 June 2012 07:36, Steve McIntyre <steve at einval.com> wrote:
> On Fri, Jun 29, 2012 at 10:08:04PM +0100, Reuben Thomas wrote:
>>On 29 June 2012 17:08, Steve McIntyre <steve at einval.com> wrote:
>>> On Sun, Jun 24, 2012 at 08:48:30AM +0100, Steve McIntyre wrote:
>>>>On Sun, Jun 17, 2012 at 10:24:15PM +0100, Reuben Thomas wrote:
>>>>>
>>>>>Ping again! Great to see the 2.5.3 release. Of the remaining bugs, I
>>>>>think UTF-8 tagging is really important to fix, and the fixes are
>>>>>available. Anything I can do to help expedite this?
>>>>
>>>>I might ask you to help test it, basically. My own usage of abcde
>>>>tends to be for generating flacs, so I'd be happy to get help from
>>>>somebody who cares more about MP3.
>>>
>>> I've just committed the changes to fix eyed3 use and switch over to
>>> it. They seem to work OK for me, but more testing would be welcome!
>>
>>There's one difference which I think is significant: in the patch for
>>issue 22, it has:
>>
>>       TAGGEROPTS="--set-encoding=utf16-LE $ID3V2OPTS"
>>
>>You've omitted the --set-encoding, but I think it's better to keep it:
>>the reason is that otherwise the default is latin1, which obviously
>>lacks most characters, and ID3v2.3 does not support utf8.
>
> Doh, pebkac here. Fixed now.

Great, this seems to work fine. I made one change: noticing that eyed3
tags with IDv2.4 by default, and since in abcde we're always adding
new tags, not altering old ones, it seems sensible and safe to set
utf8 as the default encoding.

-- 
http://rrt.sc3d.org