[Abcde-users] "CD backups" produced with "abcde -1 -o flac -a default, cue" sometimes miss the first few frames

[Nicolas Boullis]

On Sun, Aug 11, 2013 at 08:34:24AM -0800, Roger wrote:
> 
> Odd, "-a cue" doesn't seem to be listed within abcde -h.

That's odd indeed. But as far as I can see, it is properly documented in 
the manpage (unless it is Debian-specific).

> 
> >--- /usr/bin/abcde.distrib	2012-06-16 17:08:33.000000000 +0200
> >+++ /usr/bin/abcde	2013-08-11 17:14:37.000000000 +0200
> >@@ -2894,11 +2894,11 @@
> > 		LASTTRACK=$(expr $3 + 0)
> > 		UTRACKNUM=$FIRSTTRACK
> > 		case "$CDROMREADERSYNTAX" in
> >-			flac) READTRACKNUMS="$FIRSTTRACK.1-$(($LASTTRACK + 1)).0" ;;
> >+			flac) READTRACKNUMS="-" ;;
> > 			cdparanoia)
> > 				#XX FIXME XX
> > 				# Add a variable to check if tracks are provided in command line and if not, use "0-" to rip the tracks
> >-				READTRACKNUMS="$FIRSTTRACK-$LASTTRACK" ;;
> >+				READTRACKNUMS="0-" ;;
> > 			cdda2wav | icedax) READTRACKNUMS="$FIRSTTRACK+$LASTTRACK" ;;
> > 			*) echo "abcde error: $CDROMREADERSYNTAX does not support ONETRACK mode"
> > 				exit 1 ;;
> 
> 
> Does the last change seem to conflict with the comment above "# FIXME" comment?  
> In otherwords, maybe omitting the FIXME comment as it's irrelevant after 
> changing to it's suggested "0-" definition due to apparent failure?

You are right: the FIXME comment is irrelevant with my patch.


> Or, maybe something along the lines of:
> 
> if CHECK_SOME_VARIABLE 'doesn't do what I want' then READTRACKNUMS="0-" 
> (because 'READTRACKNUMS="$FIRSTTRACK-$LASTTRACK" isn't doing what I want?)

I don't think that would be relevant. I'd rather not uselessly bloat the 
code. Currently, as I understand it, onetrack mode is only available for 
the whole disc rather than for a part of it, and READTRACKNUMS="0-" is 
the right way to dump the whole disc.


Cheers,

-- 
Nicolas Boullis