[Abcde-users] does musicbrainz work in 2.9.3 ???

[Alan W. Kerr]

I *know*... it makes no sense!

Alan


On 6/19/20 3:25 PM, Steve McIntyre wrote:
> On Fri, Jun 19, 2020 at 03:01:34PM -0600, Alan W. Kerr wrote:
>> OK, how is musicbrainz supposed to work in 2.9.3???  the same problem existed
>> in 2.9.1 but not in 2.8.1.  So when was this changed and what was the change
>> supposed to do?
> 
> The change went in over 2 years ago:
> 
> commit 381cfc54e7e4c406cc0d645427a6d8c60d4606e9
> Author: Steve McIntyre <steve at einval.com>
> Date:   Wed Feb 21 18:10:53 2018 +0000
> 
>      Add support for storing musicbrainz lookups at chosen result numbers
>      
>      Pre-requisite for the support for multiple lookup tools. Add the
>      "--start N" command line option to tell abcde-musicbrainz-tool to
>      start storing its results at cddbread.N instead of assuming
>      cddbread.1.
> 
> and it was in the 2.9 release.
> 
>> line 2690 is:
>> ${MUSICBRAINZ} --command data --discid "${MBDISCID}" --workdir
>> "${SOURCE_WORKDIR}" --start ${NUM_CDDB_MATCHES}
>>
>> ${MUSICBRAINZ} resolves to abcde-musicbrainz-tool and the problem is the
>> "--start" switch (because it doesn't exist in abcde-musicbrainz-tool).
>>
>> the error is:
>> =====
>> Unknown option: start
>> Usage:
>>      abcde-musicbrainz-tool [options]
>>
>>      Options:
>>        --command {id|data|calcid} mode of operation (default: id)
>>        --device <DEV>             read from CD-ROM device DEV (default:
>> /dev/cdrom)
>>        --discid <ID>              Disc ID to query with --command data.
>>        --discinfo <F> <L> <LI> <LO> <TRK1OFF> [<TRK2OFF> [...]]
>>                                   Disc information for --command calcid.
>>        --workdir <DIR>            working directory (default: /tmp)
>>        --help                     print option summary
>>        --man                      full documentation
>>
>> [ERROR] abcde: abcde-musicbrainz-tool failed to run; ABORT
>> =====
> 
> ... but I forgot to update the usage text to mention the --start change.
> 
>>
>> so, there's no --start switch... *HOW* has anyone gotten this to run???
>> HOW has no one else noticed this???
> 
> I'm using this code every time I run abcde locally...
>