[Abcde-users] [PATCH 3/6] Remove default cddb choice of 1 on empty input

Snild Dolkow snild at dolkow.se
Sun Aug 20 08:36:55 BST 2023


This behavior is not clearly indicated in the prompt, and I believe it's
better to force an explicit choice.
---
 abcde | 1 -
 1 file changed, 1 deletion(-)

diff --git a/abcde b/abcde
index 35c0bed..5d86b35 100755
--- a/abcde
+++ b/abcde
@@ -2921,7 +2921,6 @@ do_cddbedit ()
 					while [ $CDCHOICENUM -lt 0 ] || [ $CDCHOICENUM -gt $NUM_CDDB_MATCHES ]; do
 						echo -n "Which entry would you like abcde to use (0 for none)? [0-$NUM_CDDB_MATCHES]: " >&2
 						read CDDBCHOICE
-						[ X"$CDDBCHOICE" = "X" ] && CDDBCHOICE=1
 						if echo $CDDBCHOICE | grep -E "[[:space:]]*[[:digit:]]+,[[:digit:]]+[[:space:]]*" > /dev/null 2>&1 ; then
 							if [ ! X"$DIFF" = "X" ]; then
 								PARSECHOICE1=$(echo $CDDBCHOICE | cut -d"," -f1 | xargs printf %d 2>/dev/null)
-- 
2.41.0




More information about the Abcde-users mailing list