[Abcde-users] FW: Abcde and aiff

[Gabriel Rosenkoetter]

On 2025-04-22 04:24, josh wrote:
> My apologies but I was too hasty to declare that abcde does not tag aiff 
> files. It does tag them during the encoding action.
> 
> Here is the link to the relevant function:
> 
> https://github.com/poddmo/abcde/ 
> blob/6e7795eb5fe951e9a6b2c32083cecb0c82e423c2/abcde#L1432
> 
> and copy and paste for quick reference:
> 
> aiff)
>      case "$AIFFENCODERSYNTAX" in
>          ffmpeg)
>              if [ "$DOTAG" = "y" ]; then
>                  $RUN_COMMAND nice $EFFECTIVE_NICE $AIFFENCODER -i "$IN" 
> $AIFFENCODEROPTS \
>                   -metadata artist="$TRACKARTIST" -metadata 
> album="$DALBUM" \
>                   -metadata title="$TRACKNAME" -metadata 
> track="${TRACKNUM:-$1}" \
>                   -metadata date="$CDYEAR" -metadata genre="$CDGENRE" \
>                   -metadata comment="$COMMENT" "$OUT"
>              else
>                  $RUN_COMMAND nice $EFFECTIVE_NICE $AIFFENCODER -i "$IN" 
> $AIFFENCODEROPTS "$OUT"
>              fi
>          ;;
>      esac
> ;;

Huh.

Are $TRACKARTIST, $TRACKNAME, and so forth populated when that code path 
executes?

Of course I could check, but you're way closer to this code base at this 
point. :^>

To be clear, I expect the results of the CDDB query are populated in the 
disc file (which, actually, is another thing to check, but it's unlikely 
that'd affect *all* of the discs that Dry [etc] is trying to rip) and 
all at that point, but I'm not sure that those data are actually in the 
right variables before the "tag" step.



-- 
Gabriel Rosenkoetter (he/him)
gr at eclipsed.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <http://lists.einval.com/pipermail/abcde-users/attachments/20250422/71e7b897/attachment.sig>