[Abcde-users] abcde 2.8.1 release

[Matthias Andree]

Am 18.01.2017 um 15:02 schrieb Steve McIntyre:
> Hi folks,
>
> I've just released abcde version 2.8.1, and it's ready for download from
> the normal location:
>
>  https://abcde.einval.com/download/
>
> This is a brown paper bag release - it just contains one fix for a
> stupid bug I introduced in 2.8 in abcde-musicbrainz-tool - see
>
>   https://abcde.einval.com/bugzilla/show_bug.cgi?id=52
>
> for details. I fixed bug 30, but didn't test it well enough. Sorry!

Greetings,

I've recently tried to rip a CD that has not had musicbrainz data, but
CD-TEXT, and accented characters (French on the album title, and Spanish
in the track titles), and ultimately, abcde messed up the file naming
royally, files remaining in the output.

There's a detailed bug report, in
<https://abcde.einval.com/bugzilla/show_bug.cgi?id=53> and I am
proposing partial fixes, attached here and also uploaded to the bug. 
These fixes currently assume eyeD3 for ID3v2.4 tagging on MP3, and also
work with metaflac, and assume the code runs in a UTF-8 locale.

What I found to be particularly harmful was ISO-8859-1 as bare input in
my de_DE.UTF-8 locales, causing all sorts of breakage in grep and sed;
cddb-tool lacked the "-a" option to grep throughout. ISO-8859-1 in my
case came from CD-TEXT, but might also from a FreeDB (CDDB) mirror when
using a protocol version 5 or older, or with broken data.

These patches however are known to be broken on eyeD3 for non-UTF-8
locales (such as LC_ALL=C), so they aren't complete.

Generally, abcde needs to see to properly encoding and re-encoding and
possibly charset-transform its data.

Future direction: (not to be done by me, I've spent half a day figuring
this out) is sorting out encodings properly, on all the providers (CDDB,
CD-TEXT, musicbrainz), on-screen editing, all the taggers, and using
iconv or recode or possibly uconv (from IBM's ICU toolkit) to get data
in the right charset and encodings.

Cheers,
Matthias
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-cddb-tool-force-grep-to-read-binaries-as-text.patch
Type: text/x-patch
Size: 4214 bytes
Desc: not available
URL: <http://lists.einval.com/pipermail/abcde-users/attachments/20170129/d0fe875f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Locale-fixes-and-optimization-for-CD-TEXT-lookup.patch
Type: text/x-patch
Size: 3579 bytes
Desc: not available
URL: <http://lists.einval.com/pipermail/abcde-users/attachments/20170129/d0fe875f/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.einval.com/pipermail/abcde-users/attachments/20170129/d0fe875f/attachment.sig>