[Abcde-users] Major changes before a new release - please help test!

[Alan W. Kerr]

found the following error:

line 4082:
while getopts 1a:bBc:C:d:DefgGhj:klLmMnNo:pP:Q:r:s:S:t:T:UvVxX:w:W:z opt 
; do

should be:
while getopts 1a:bBc:C:d:DefgGhj:klLmMnNo:pPQ:r:s:S:t:T:UvVxX:w:W:z opt ; do

ie: P: -> P , P has no $OPTARG


Alan W. Kerr          awkerr at aoc.nrao.edu          Whee!(tm)



On 02/28/2018 07:49 PM, Steve McIntyre wrote:
> Hey folks,
> 
> I've been doing some major hacking on abcde over the last couple of
> weeks, picking up on lots of bugs and also making big changes in the
> CD lookup code. This is all looking good for a release soon. Yay!
> 
> However, I've also run "shellcheck" across the code as suggested in
> one of our bugs and it showed *lots* of places in particular where
> variable quoting was missing/unsafe. I've worked through hundreds of
> such warnings and fixed most that I think make sense, so that's
> good. BUT: the changes are quite intrusive and there's a good chance
> that I may have broken functionality inadvertently. In the absence of
> a comprehensive test suite, I'm asking for help... :-)
> 
> If you can grab the latest code from git and test that it works OK for
> you, please do and respond here with any positive or negative
> feedback. The repo is at
> 
>    https://git.einval.com/cgi-bin/gitweb.cgi?p=abcde.git;a=summary
> 
> I'd like to get any bugs created here detected and fixed before a new
> release - it would be frustrating to find them afterwards.
> 
> NB: If you're using Musicbrainz, you'll need to make sure you have
> WebService::MusicBrainz 1.0.4 installed for abcde-musicbrainz-tool to
> work now.
> 
> Thanks!
>