[Abcde-users] abcde bug fixes and enhancements available

[Snild Dolkow]

I think it would be good if you, instead of importing the code via
plain dump in [1], based your github repo on the upstream one ([2]).
This will preserve the existing history, and is likely to make pulls
from your repo easier.

Similarly, you should strive to preserve the authorship of your applied
commits. As it stands, the listed author and dates of the changes (e.g.
the ones from me) in your repo are incorrect.

>From the archives, this is most easily done by downloading the relevant
monthly archive file from [3], and (after unpacking) run e.g. `git am -
i 2023-August.txt`. This will ask you for each email whether or not to
try to apply the patch.

If the mail list was noisier, making iteration through all messages
inconvenient, you can first split the archive file into individual
emails with `mkdir 2023-aug; git mailsplit -o2023-aug -- 2023-
August.txt`, then use `git am` on individual files in the extracted
folder.

>From the bug tracker, posted patch files should be possible to apply
the same way. Posted snippets are a bit iffier, since they don't
necessarily come with a commit message or other metadata. For proper
attribution, I'd recommend adding a `Suggested-by:` tag at the bottom
of the commit message, in addition to the issue link (which you seem to
have done a good job of including).

[1] https://github.com/poddmo/abcde/commit/6e8d7b65e9e8fa72cdd44b3c781e72a623e71bc8
[2] https://git.einval.com/cgi-bin/gitweb.cgi?p=abcde.git
[3] https://lists.einval.com/pipermail/abcde-users/

//Snild

On Sun, 2024-07-07 at 14:02 +1000, josh wrote:
> I've ripped hundreds of CD's with abcde and before I embark on the
> next few hundred, I wanted to fix some bugs and have a go at some
> enhancements. I've been doing this over the last few months and I've
> posted my changes to github:
> https://github.com/poddmo/abcde
> 
> The bug fixes come from patches attached to bugzilla or posted to the
> mailing list. I tried for a while to keep track of what came from
> where but my github commit log is the best reference for changes:
> https://github.com/poddmo/abcde/commits/main/
> 
> I've now tagged this version as 2.10-RC1 to recognise all the
> changes. The main new features are:
> * cddb choices show the year of release
> * cddb choice has a help and re-list option. The help also has
> details
> about how to diff two releases
> * Improved handling of CD sets. 
> - The -W option is expanded to optionally also take the total number
> of discs in the set. That number is used for a DISCTOTAL FLAC tag
> - If DISCNUMBER is greater than 1, default to append playlist rather
> than erase
> * Define a local file and directory for album art. If the album
> artwork download fails or the user chooses to overide the downloaded
> art, abcde will look for ALBUMARTDIR/ALBUMARTFILE before asking the
> user to manually enter the filename.
> * Created munge helper functions:munge_fs-safe: remove characters
> that
> are not Windows and Linux file-system safe or sanemunge_Startcase:
> capitalise the first letter of every wordmunge_unicodetoascii:
> transliterate Unicode to ASCIImunge_collapsewhitespace: replace
> multiple spaces with a single space
> * Add new mungefilename config example to use munge helper functions
> * Create new config option STARTCASEFLACTAGS to use munge_Startcase
> for FLAC tags artist name, album title and track titles
> - This helps to prevent artist duplication due to inconsistent
> capitalisation
> I'll now test this version with a few tens of CDs. I'm only
> converting to FLAC so I would appreciate any feedback if you
> use other formats. Please report issues to the github page with the
> command line, your config file and details of the audio CD that
> you're ripping.
> _______________________________________________
> Abcde-users mailing list
> Abcde-users at lists.einval.com
> https://lists.einval.com/cgi-bin/mailman/listinfo/abcde-users

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.einval.com/pipermail/abcde-users/attachments/20240707/324ed099/attachment-0001.htm>