[Abcde-users] abcde bug fixes and enhancements available

josh poddmo at gmail.com
Mon Jul 8 04:31:00 BST 2024


On Sun, 7 Jul 2024 at 18:15, Snild Dolkow <snild at dolkow.se> wrote:
>
> I think it would be good if you, instead of importing the code via plain dump in [1], based your github repo on the upstream one ([2]). This will preserve the existing history, and is likely to make pulls from your repo easier.
>
> Similarly, you should strive to preserve the authorship of your applied commits. As it stands, the listed author and dates of the changes (e.g. the ones from me) in your repo are incorrect.
>
> From the archives, this is most easily done by downloading the relevant monthly archive file from [3], and (after unpacking) run e.g. `git am -i 2023-August.txt`. This will ask you for each email whether or not to try to apply the patch.
>
> If the mail list was noisier, making iteration through all messages inconvenient, you can first split the archive file into individual emails with `mkdir 2023-aug; git mailsplit -o2023-aug -- 2023-August.txt`, then use `git am` on individual files in the extracted folder.
>
> From the bug tracker, posted patch files should be possible to apply the same way. Posted snippets are a bit iffier, since they don't necessarily come with a commit message or other metadata. For proper attribution, I'd recommend adding a `Suggested-by:` tag at the bottom of the commit message, in addition to the issue link (which you seem to have done a good job of including).
>
> [1] https://github.com/poddmo/abcde/commit/6e8d7b65e9e8fa72cdd44b3c781e72a623e71bc8
> [2] https://git.einval.com/cgi-bin/gitweb.cgi?p=abcde.git
> [3] https://lists.einval.com/pipermail/abcde-users/
>
> //Snild

Thank you kindly for the reply. I really admire your git fu as I am
less than a novice and only used the web interface to upload files. I
humbly apologise for not getting your attribution correct.
There is a growing pile of CDs on my desk (a friend gave me 15 CDs
yesterday and last night I bought 2 new CDs at a gig!) and I am driven
by function over form. I understand the abcde project is a bit dormant
as most people ripped their collection years ago and it's a done deal.
But I really needed to make these changes to improve my ripping
workflow.
Feel free to send me pull requests to my github project or push any
patches back upstream.
Cheers



More information about the Abcde-users mailing list